Skip to content

Avoid creating byte[] multiple times #35276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid creating byte[] multiple times #35276

wants to merge 1 commit into from

Conversation

brucelwl
Copy link

@brucelwl brucelwl commented Aug 3, 2025

for issue #35261

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 3, 2025
@bclozel bclozel added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Aug 3, 2025
@bclozel
Copy link
Member

bclozel commented Aug 3, 2025

Thanks for the proposal but this PR fails the build and does not implement the content length contract anymore.
I see that it could make performance better but we should not sacrifice correctness.

@bclozel bclozel closed this Aug 3, 2025
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 3, 2025
@bclozel bclozel mentioned this pull request Aug 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brucelwl @bclozel @spring-projects-issues